Remove legacy torchtext code from Transformer tutorial #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit c684eb3 https://deploy-preview-1251--pytorch-tutorials-preview.netlify.app |
zhangguanheng66
force-pushed
the
transformer_tutorial
branch
from
2e6d0cf to
8ca5d8a
Compare
cpuhrsch
reviewed
Nov 20, 2020
| encoding="utf8")))) | ||
|
|
||
| def data_process(raw_text_iter): | ||
| data_ = [torch.tensor([vocab[token] for token in tokenizer(item)], |
There was a problem hiding this comment.
nit: instead of data_ use data
cpuhrsch
approved these changes
Nov 20, 2020
zhangguanheng66
changed the title
|
cc @brianjo |
|
Hey George, taking a look at this now. |
zhangguanheng66
force-pushed
the
transformer_tutorial
branch
from
00ee006 to
c27f59a
Compare
zhangguanheng66
force-pushed
the
transformer_tutorial
branch
from
7389161 to
c684eb3
Compare
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
* checkpoint * remove dataloader * checkpoint * Fix ascii decode error Co-authored-by: Guanheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.