This repository was archived by the owner on Jul 19, 2019. It is now read-only.
[fixed]: check item length before calling scrollinto view #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the state of highlightIndex will not be set to null when I change the value of input box, so exception will be thrown when it is going to find the highlighted dom element
|
@xujihui1985 think you could get this rebased so we can include it for 1.0.0 in #109? |
|
ok. glad to do that |
|
Superseded by #139. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the state of highlightIndex will not be set to null when I change
the value of input box, so exception will be thrown when it is going
to find the highlighted dom element