Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

new build in order for wrapperStyles and wrapperProps to work as expected #97

Closed
wants to merge 3 commits into from

Conversation

hontas
Copy link
Contributor

@hontas hontas commented Apr 28, 2016

Resolves the hard coded display: inline-block that is in the current build.
And let's us set wrapperStyle and wrapperProps like in examples and in the source.

@hontas hontas mentioned this pull request Apr 28, 2016
@robcalcroft
Copy link

Looks good, might want to consider amending the commit message to be more descriptive?

@hontas
Copy link
Contributor Author

hontas commented Apr 29, 2016

like why it's a new build - is that what you mean @robcalcroft?

@robcalcroft
Copy link

@hontas I meant more of a description of the PR itself, if I were to do a git log and see new build, I'd have little idea of what changes that commit made. Eg Resolves the hard coded display: inline-block would be more descriptive.

@hontas hontas changed the title new build new build in order for wrapperStyles and wrapperProps to work as expected Apr 29, 2016
@hontas
Copy link
Contributor Author

hontas commented Apr 29, 2016

@robcalcroft fair point ;) is this ok?

@robcalcroft
Copy link

Yeh that works a lot better 👍

@hontas
Copy link
Contributor Author

hontas commented Apr 29, 2016

resolves #66

@rich-b
Copy link

rich-b commented May 3, 2016

👍

@hontas
Copy link
Contributor Author

hontas commented May 5, 2016

@robcalcroft any plans on merging and publishing a patch to npm?

@robcalcroft
Copy link

@hontas I'm not a contributer on this project sorry

@hontas
Copy link
Contributor Author

hontas commented May 5, 2016

@ryanflorence any planson merging this PR and publishing a patch to npm? Without it wrapperStyle and wrapperProps is broken..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants