Backend: emit annotations #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
force-pushed
the
backend-annotations
branch
from
94ce66f to
628bb24
Compare
|
rebased. |
|
Wow that's really hairy. Annotations in the JVM are such a mess. The commit LGTM as far as I can see. |
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Jul 3, 2025
Backport "Revert "Make overload pruning based on result types less aggressive (scala#21744)" in main" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotations are not emitted on arguments of backend-generated static forwarders.
Backend used to use type of method that it forwards to generate those annotations.
In dotty, there's way to get from this type to symbols of arguments.
@odersky please review. I know that this code is hard to review. But java tests actually include good coverage of annotations, including complex nested ones, so this code should be correct.