TypeErasure#erasure: do not semi-erase types by default #680
+34
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
simplify/erasure
branch
from
c01be5b to
cb9a509
Compare
|
Alternatively, we could make semi-erasure a Typer mode I think, but I'm not sure that this would make things clearer. |
This method can be called from other phases than Erasure, and in most cases we do not want the result to be semi-erased as this is an implementation details of value classes only useful to do type adaptation in the Erasure phase.
smarter
force-pushed
the
simplify/erasure
branch
from
cb9a509 to
2ab8aac
Compare
After the previous commit this special case is not needed anymore, TypeErasure#erasure does the correct thing for value classes.
smarter
force-pushed
the
simplify/erasure
branch
from
2ab8aac to
d4d2ada
Compare
|
I think it would be better to have a method semiErasure alongside erasure instead of spreading the boolean parameter everywhere. |
|
LGTM. I'll merge and then try to get rid of SemiEraseVCs altogether. |
odersky
added a commit
that referenced
this pull request
Jun 26, 2015
TypeErasure#erasure: do not semi-erase types by default
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can simplify
ClassOf.Review by @DarkDimius .