-
Notifications
You must be signed in to change notification settings - Fork 167
[chore][chef] Run tests against locally built artifact #6333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
577e379
to
75a4c79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6333 +/- ##
==========================================
+ Coverage 36.83% 44.81% +7.97%
==========================================
Files 381 390 +9
Lines 26732 26995 +263
==========================================
+ Hits 9848 12099 +2251
+ Misses 15908 14023 -1885
+ Partials 976 873 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
source "#{node['splunk_otel_collector']['windows_repo_url']}/splunk-otel-collector-#{collector_version}-amd64.msi" | ||
action :create | ||
only_if { !::File.exist?(node['splunk_otel_collector']['collector_version_file']) || (::File.readlines(node['splunk_otel_collector']['collector_version_file']).first.strip != collector_version) } | ||
remote_destination_path = "#{ENV['TEMP']}/splunk-otel-collector-#{collector_version}-amd64.msi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collector_version
may not actually match the local artifact's version, but for simplicity of the remaining logic I figure there isn't much harm in keeping the name the same for testing.
…n when local artifact testing
…erpolation or special symbols.
…ally be installed
5badc9c
to
ab5a4c5
Compare
- name: Extract artifacts | ||
run: | | ||
mkdir -p files | ||
deb_path=$(find /tmp/deb-amd64-package/splunk-otel-collector*amd64.deb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all three paths, deb_path
, rpm_path
, and msiPath
, we're relying on the directories to only have a single file that matches the regex. This might fail in the future if built artifacts change names, or end up having more than one matching artifact.
Description:
Same idea as #6284, updating Chef tests to run against locally built artifacts.
local_artifact_testing_enabled
that will install the collector from a local artifact when set to true.