Skip to content

docs: improvements to the devtools-json docs #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

benmccann
Copy link
Member

Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 727fb33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link

pkg-pr-new bot commented Jun 19, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@598
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@598

commit: 727fb33

@manuel3108
Copy link
Member

Ignore the failing tests here, they are currently broken for the cli

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but if we were to add the env var to sveltejs/kit#13905 then we should mention it here, since the message says 'learn how to prevent this message' and right now the only answer presented is to install the plugin. The alternative would be to add a note explaining how to deal with it in the handle hook or with an actual route

@Conduitry
Copy link
Member

Commented on sveltejs/kit#13905 (comment) - The env var to suppress the log seems weird. We shouldn't make this be a mixture of the project author's responsibility and the project runner's responsibility.

@Rich-Harris
Copy link
Member

opened a PR against this one that removes the default selection #605

* dont select devtools-json by default

* Create brown-peas-shop.md

---------

Co-authored-by: Manuel <[email protected]>
@manuel3108
Copy link
Member

Mhmm, looks like the site is not building anymore:
https://vercel.com/svelte/svelte-dev/ForS5tm9bQLSHLabKYHMzmKtzdVz?filter=errors

These errors were not marked as being expected: 1127 1005 1160.
Expected: // @errors: 1127 1005 1160
Compiler Errors:
ambient-kit.d.ts
[1127] 374 - Invalid character.
[1127] 375 - Invalid character.
[1005] 377 - ';' expected.
[1160] 416 - Unterminated template literal.

Any ideas why? Code snipped looks correct for me. Feel free to merge once fixed. Same goes for the changesets pr, thats going to appear seconds after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants