-
-
Notifications
You must be signed in to change notification settings - Fork 42
docs: improvements to the devtools-json
docs
#598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
benmccann
commented
Jun 19, 2025
- you won't get that error log anymore, but will get the message in fix: warning for chrome devtools requests now suggests sv instead of vite plugin kit#13905
🦋 Changeset detectedLatest commit: 727fb33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Ignore the failing tests here, they are currently broken for the cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but if we were to add the env var to sveltejs/kit#13905 then we should mention it here, since the message says 'learn how to prevent this message' and right now the only answer presented is to install the plugin. The alternative would be to add a note explaining how to deal with it in the handle
hook or with an actual route
Commented on sveltejs/kit#13905 (comment) - The env var to suppress the log seems weird. We shouldn't make this be a mixture of the project author's responsibility and the project runner's responsibility. |
Co-authored-by: Rich Harris <[email protected]>
opened a PR against this one that removes the default selection #605 |
* dont select devtools-json by default * Create brown-peas-shop.md --------- Co-authored-by: Manuel <[email protected]>
Mhmm, looks like the site is not building anymore:
Any ideas why? Code snipped looks correct for me. Feel free to merge once fixed. Same goes for the changesets pr, thats going to appear seconds after. |