Skip to content

chore: don't select devtools-json by default #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

Rich-Harris
Copy link
Member

PR against #598 — reverts all the defaultSelection stuff in #581. Not sure if the tests will need updating, I can't get them to run locally, it gives me a bunch of errors about a missing @sveltejs/ast-tooling package that I don't really understand

Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 6722483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 20, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@605
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@605

commit: 6722483

@jycouet
Copy link
Contributor

jycouet commented Jun 20, 2025

I see this topic is raising lots of convo/changes. I thought default selection was a nice idea, after reflexion, maybe not.

Hope it's all good. Don't hesitate to push me the stuff.

Thx for everything

@manuel3108 manuel3108 changed the title don't select devtools-json by default chore: don't select devtools-json by default Jun 21, 2025
@manuel3108 manuel3108 merged commit 727fb33 into benmccann-patch-1 Jun 21, 2025
7 checks passed
@manuel3108 manuel3108 deleted the undo-default-selection branch June 21, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants