fix: silence $inspect
errors when the effect is about to be destroyed
#16391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16386 got me thinking — what if instead of making these errors less scary we just didn't show them?
In this PR, if an error occurs while reading
$inspect(value)
, we don't print it immediately. Instead, we stash it. Then, in a sibling render effect, we read the value again (so that the two effects have the same dependencies) and log the error if it occurred.In 99% of cases (the cases like #16280 (comment)) the render effect will be destroyed before this happens. In the remaining 1%, the error is still logged, with the same stack trace, just a nanosecond later.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint