use ordered list start index when rendering #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@swift-ci test |
mportiz08
approved these changes
Dec 8, 2021
|
Going to go ahead and merge this since the change is ready and backwards compatible with existing JSON data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://73847907
Summary
While cmark-gfm saves the starting index of an ordered list, swift-markdown and Swift-DocC currently discards this information. This PR is part of a set that preserves the starting index when rendering documentation.
Dependencies
Testing
Build this branch, then follow the testing instructions on swiftlang/swift-docc#53.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded