Enhance fixup target to use plutil and get correct xctest path #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this is twofold: * `defaults` will not longer support this in the future, as per man page > WARNING: The defaults command will be changed in an upcoming major release to only operate on preferences domains. General plist manipulation utilities will be folded into a different command-line program. * this may help address some failures in Swift CI related to the execution of this command Addresses rdar://63984731
|
@swift-ci please smoke test |
ddunbar
changed the title
|
Thanks for the PR! Your commit title is backwards. :) |
|
Thanks for catching my typo 😄 |
ddunbar
approved these changes
Jun 4, 2020
jakepetroules
approved these changes
Jun 4, 2020
Also add explicit dependency of the fixup target on the bundle target
|
@swift-ci please smoke test |
edymtt
changed the title
|
Rerequesting reviews since the PR scope is slightly expanded now. |
edymtt
changed the title
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reason to use plutil
defaultswill no longer support this in the future, as per man pageplutilprints more meaningful errors that help in troubleshooting CI issuesIndeed this switch helped uncover an issue with the logic inferring the path of
XcodePerfTests.xctest.Addresses rdar://63984731