[5.3] Enhance fixup target to use plutil and get correct xctest path #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reason to use plutil * defaults will no longer support this in the future, as per man page > WARNING: The defaults command will be changed in an upcoming major release to only operate on preferences domains. General plist manipulation utilities will be folded into a different command-line program. * plutil prints more meaningful errors that help in troubleshooting CI issues Indeed this switch helped uncover an issue with the logic inferring the path of XcodePerfTests.xctest. Addresses rdar://63984731 (cherry picked from commit 145c113,
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
(I would need to restart the PR testing later, as I initially selected by mistake master instead of release/5.3) |
|
@swift-ci please smoke test |
dmbryson
approved these changes
Jun 10, 2020
edymtt
pushed a commit
to edymtt/swift
that referenced
this pull request
Jun 11, 2020
We were accidentally using the system libicu instead of building it, causing version mismatches. This will unblock Linux PR testing for swiftlang/swift-llbuild#674 (cherry picked from commit ccb41f0, swiftlang#31733)
|
Please test with following pull request: @swift-ci Please smoke test Linux platform |
edymtt
added a commit
to swiftlang/swift
that referenced
this pull request
Jun 11, 2020
) We were accidentally using the system libicu instead of building it, causing version mismatches. This will unblock Linux PR testing for swiftlang/swift-llbuild#674 (cherry picked from commit ccb41f0, #31733) Co-authored-by: Ben Langmuir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reason to use plutil
issues
Indeed this switch helped uncover an issue with the logic inferring the
path of XcodePerfTests.xctest.
Addresses rdar://63984731
(cherry picked from commit 145c113, #673)