-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Module selectors (formerly module qualifiers) #28834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I’m unfortunately running out of time to work on this, so I’ll need clean it up and land it behind a feature flag to keep it from rotting. |
This breaks some diagnostics in expr/primary/unqualified_name.swift; I’ll continue adding the feature and then revisit these to see how I can support them.
This is a first cut at how imports ought to adopt module selectors.
It will soon need to allocate sometimes.
4de501a
to
04f95bf
Compare
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
The history of this PR is actually a gigantic fiction and so some of the fix-it source locations are incorrect. Sorry about that.
#28936 broke this branch; force-pushed to correct the code. |
@swift-ci please test |
Build failed |
Build failed |
This pull request begins to implement "module selectors", which allow references to declarations to be unambiguously prefixed with a module they can be found through:
This PR parses module selectors and partially implements lookup and diagnostics for them. The new functionality is hidden behind an
-enable-experimental-module-selector
frontend flag. There is one diagnostic regression with that flag enabled, but I've made sure that it keeps working when the diagnostic is disabled.I will need to switch to other tasks soon, so I plan to merge this work in its current incomplete state to keep it from rotting in a branch.
Makes progress on rdar://problem/19481048.