Skip to content

Implement experimental module selectors (MyMod::someName) feature #34556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Nov 3, 2020

This pull request begins to implement "module selectors", which allow references to declarations to be unambiguously prefixed with a module they can be found through:

class MyClass: ObjectiveC::NSObject {}  // OK, ObjectiveC defines NSObject
class MyClass: Foundation::NSObject {}  // OK, Foundation re-exports NSObject
class MyClass: Swift::NSObject {}       // error, Swift does not re-export or define NSObject
class MyClass: MyModule::NSObject {}    // error, MyModule does not re-export or define NSObject

This PR parses module selectors and partially implements lookup and diagnostics for them. The new functionality is hidden behind an -enable-experimental-module-selector frontend flag. There is one diagnostic regression with that flag enabled, but I've made sure that it keeps working when the diagnostic is disabled.

This work was previously in PR #28834, which was closed during the master-to-main transition. I've updated it to work on modern compilers, including removing some FIXMEs for bad diagnostics that have improved since December 2019.

Makes progress on rdar://problem/19481048.

@beccadax beccadax changed the title Module selectors Implement experimental module selectors (MyMod::someName) feature Nov 3, 2020
@beccadax beccadax force-pushed the mod-squad-2 branch 3 times, most recently from eb8ecdf to b6d41f6 Compare July 21, 2021 20:18
@nkcsgexi
Copy link
Contributor

Woohoo! Thank you for reviving this, Becca!

beccadax added 3 commits May 15, 2025 16:29
This breaks some diagnostics in expr/primary/unqualified_name.swift; I’ll continue adding the feature and then revisit these to see how I can support them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants