Make initial changes for module selectors #81459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
xymus,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
xymus
approved these changes
May 12, 2025
|
@swift-ci please test |
beccadax
force-pushed
the
mod-squad-serialize
branch
from
6208845 to
57a3fa3
Compare
It will soon need to allocate sometimes.
There are four attributes which serialize out a DeclNameRef, sometimes by dropping some of its components. Standardize them with a representation that can handle module selectors.
beccadax
force-pushed
the
mod-squad-serialize
branch
from
57a3fa3 to
b6be852
Compare
|
@swift-ci please test |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…rialize" This reverts commit 36de3a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some baby steps towards module selectors (#34556):
DeclNameRef's API.DeclNameRefs.DeclNameRefin the same way, using a separate record. Previously each of the four serialized itsDeclNameRefin a different, ad-hoc manner, often lossily.These changes have been separated out because they're easy to do early and relatively likely to cause merge conflicts.