[Diagnostics] Make sure extension type repr is available before using it #37887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked with Robert and it appears that adding a test-case for this would be too cumbersome. |
|
@swift-ci please smoke test |
CodaFi
reviewed
Jun 12, 2021
|
|
||
| if (auto noteLoc = nameRepr->getEndLoc()) { | ||
| note.fixItInsertAfter(noteLoc, " where Self == <#Type#>"); | ||
| } | ||
| } |
There was a problem hiding this comment.
If you don't have the extended type repr, you should have the extended type. Can that be diagnosed even if it can't be fixed?
There was a problem hiding this comment.
It would be diagnose, just wouldn't have the note.
|
@swift-ci please smoke test |
Before suggesting to add `where Self == ...` condition to the extension of a protocol involved in a static member lookup, let's check whether type repr is available and valid. Resolves: rdar://78097387
|
@swift-ci please smoke test |
hborla
approved these changes
Jun 15, 2021
|
@swift-ci please clean smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before suggesting to add
where Self == ...condition to the extensionof a protocol involved in a static member lookup, let's check whether
type repr is available and valid. It might not be available when e.g. extension
was loaded from a serialized module.
Resolves: rdar://78097387