[SwiftCore] Enable explicit module builds #80354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit module builds help prevent the dependency scanner from getting lost and attempting to pull the SwiftShims module from the resource directory, existing SDK, and the just-built standard library. They aren't part of the library interface, but make it possible to build the runtime libraries without seeing duplicate shims. Moving the flag to a top-level compile command.
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@al45tair, this should fix the duplicate module issue you were seeing before. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
compnerd
approved these changes
Mar 28, 2025
al45tair
approved these changes
Mar 28, 2025
Looks like maybe the Regex code isn't compatible with explicit modules for some reason. |
|
Yeah, that should be fixed by #80362. |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit module builds help prevent the dependency scanner from getting lost and attempting to pull the SwiftShims module from the resource directory, existing SDK, and the just-built standard library. They aren't part of the library interface, but make it possible to build the runtime libraries without seeing duplicate shims. Moving the flag to a top-level compile command.