Allow converter failures to fail workflow and other minor things #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
changed the title
Sushisource
approved these changes
Jun 20, 2023
README.md
Outdated
| @@ -306,8 +306,8 @@ This notably doesn't include any `date`, `time`, or `datetime` objects as they m | |||
| Users are strongly encouraged to use a single `dataclass` for parameter and return types so fields with defaults can be | |||
| easily added without breaking compatibility. | |||
|
|
|||
| Classes with generics may not have the generics properly resolved. The current implementation, similar to Pydantic, does | |||
| not have generic type resolution. Users should use concrete types. | |||
| Classes with generics may not have the generics properly resolved. The current implementation, does not have generic | |||
There was a problem hiding this comment.
Suggested change
| Classes with generics may not have the generics properly resolved. The current implementation, does not have generic | |
| Classes with generics may not have the generics properly resolved. The current implementation does not have generic |
| True if a cancelled exception, false if not. | ||
| """ | ||
| return ( | ||
| isinstance(exception, asyncio.CancelledError) |
There was a problem hiding this comment.
Oh boy this whole thing is not fun lol
There was a problem hiding this comment.
Yeah, we basically write this same thing in every SDK
Comment on lines
+292
to
+296
| # We want failure errors during activation, like those that can | ||
| # happen during payload conversion, to fail the workflow not the | ||
| # task | ||
| try: | ||
| self._set_workflow_failure(err) |
There was a problem hiding this comment.
Making sure - this is only happening if they explicitly raise something like ApplicationError - not on any old random exception, correct?
There was a problem hiding this comment.
Correct, this catch clause is for temporalio.exceptions.FailureError only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio.exceptions.is_cancelled_exceptionhelper functionChecklist