Added include and exclude params for coverage reports (issue #6) #57
Conversation
|
Someone pls fix the builds |
| .run(conn); | ||
| .skipCompatibilityCheck(skipCompatibilityCheck); | ||
|
|
||
| for (String includeObject: finalIncludeObjectsList){ |
There was a problem hiding this comment.
This should be done in Fluent interface manner to stay within the same pattern. Will need a change in Java API. I will try to do this soon.
There was a problem hiding this comment.
Thanks for your efforts, though! Very appreciated!
There was a problem hiding this comment.
Do you mean create a function like "includeObjects" or something like that? I also can do that, in general, if you are busy now.
There was a problem hiding this comment.
Yes, creating a function in the TestRunner class, return the TestRunner instance so we can continue to use fluent interface pattern. The need to create a loop outside just to add objects feels uncomfortable to me :)
|
I recreated the PR here to get around the travis problems: #58 |
Fixes #6