Skip to content

Added include and exclude params for coverage reports (dup for issue #6) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2018

Conversation

pesse
Copy link
Member

@pesse pesse commented Dec 29, 2017

No description provided.

@jgebal
Copy link
Member

jgebal commented Dec 29, 2017

I'm just wondering.
Should we provide way to include/exclude files (paths) with mask?
That seems more consistent when looking at the project from filesystem perspective rather than from database perspective.
It would also be aligned with sonar include/exclude approach.

Any opinions?

@pesse
Copy link
Member Author

pesse commented Dec 30, 2017

I'm not using code coverage yet so I don't have experience on the matter, but I see this change as low-hanging fruit I'd like to include as similar to the db framework as possible.
At the moment I'm not sure how much benefit doing the additional effort of pattern-based include/exclude will bring.

@pesse
Copy link
Member Author

pesse commented Dec 30, 2017

@justedro: I'd like to add a system test for the code-coverage use case before merging. We don't have one yet and for include/exclude functionality only affects these use-cases I'd want to add it right now.
Don't know how long it will take - Christmas Holiday is family time so I don't have much leisure time ;)
You are of course very welcome to provide one yourself if you want to contribute even more - though thanks for the work you've already done.

Also separated unit- and system-tests for RunCommand and refactored RunCommand a bit to use the fluent api provided
@pesse pesse merged commit 2cb8ec9 into develop Jan 2, 2018
@jgebal jgebal deleted the feature/include-exclude-params branch March 20, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants