Update gold 2021 to 0.5.0rc2 #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problems in dpctl identified with Klockwork static code analysis
* Added Cython examples 1. Cython/sycl_direct_linkage Example of native extension "cdef import"-ing sycl C++ classes directly from CL/sycl.hpp Queue is created within the function, adding measurable overhead. Extension uses GEMV to compute column-wise total of a C-contiguous matrix, and illustrates linking to oneMKL. 2. Cython/sycl_bufer Example of native extension building on the above, but illustrating getting the queue from dpctl. 3. Cython/usm_memory Example of native extension allocating USM shared memory via dpctl, and using it as a buffer underlying NumPy array. Cython functions dispatches to a SYCL code that works with USM pointer. One function populates USM memory underneath NumPy array with random numbers using ``oneapi::mkl::rng::device`` function used in SYCL kernel, with random number being parameters of European vanilla options. The second function uses SYCL to price these options using Black-Scholes formula. * updated create_sycl_queues.py to run on current dpctl * Extended sycl_buffer example to implement column-wise summation without MKL * few examples illustrating MemoryUSM* objects * have it black's way * Adjusted examples section of global README.md
* Rename dppl to dpctl * Formatting fixes Co-authored-by: etotmeni <[email protected]>
Feature/program
PokhodenkoSA
reviewed
Dec 5, 2020
| @@ -1,4 +1,4 @@ | |||
| #===------------- __init__.pxd - dpctl module --------*- Cython -*----------===# | |||
| # ===------------ __init__.pxd - dpctl module --------*- Cython -*----------===# | |||
There was a problem hiding this comment.
It is not necessary to fix number of #.
Possibly @diptorupd you are using old version of black. Use 20.8b1 as pointed in CONTRIBUTING.md. Conda provides version 19.10b0. Pip provides 20.8b1.
PokhodenkoSA
reviewed
Dec 5, 2020
dpctl/__init__.py
Outdated
| ## This top-level dpctl module. | ||
| ## | ||
| ##===----------------------------------------------------------------------===## | ||
| #===----------------- __init__.py - dpctl module -------*- Cython -*--------===# |
There was a problem hiding this comment.
I do not like this line. It duplicates file name and also it lies about Cython. Conclusion: unnecessary support costs.
Lets keep only License at the header of the file and docstring with description of the content.
There was a problem hiding this comment.
Cython was an obvious mistake, should be Python. I was following the convention LLVM uses, but we can make the change.
PokhodenkoSA
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.5.0rc2 has all the renaming changes from dppl to dpctl.