Adjustments to A11y Lang Attribute section #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hergaiety
changed the title
ijlee2
reviewed
Jun 30, 2020
ijlee2
reviewed
Jun 30, 2020
ijlee2
reviewed
Jun 30, 2020
|
|
||
| Note: a page cannot have multiple language attribute _values_. For example, this means that `lang="en"` could be set on the page's HTML element and then `lang="es"` could be set on a different element in the page content (as appropriate). | ||
| The `html` element may not have multiple `lang` _values_. Instead, an element containing content in a different language than the `html`'s `lang` may be wrapped in an element with its own `lang` attribute. |
There was a problem hiding this comment.
The 2nd sentence felt a little awkward. Does the following convey your meaning well?
Suggested change
| The `html` element may not have multiple `lang` _values_. Instead, an element containing content in a different language than the `html`'s `lang` may be wrapped in an element with its own `lang` attribute. | |
| The `html` element may not have multiple `lang` _values_. If an element contains content in a language different from the primary, then you can provide the element its own `lang` attribute. |
ijlee2
reviewed
Jun 30, 2020
ijlee2
reviewed
Jun 30, 2020
ijlee2
requested changes
Jun 30, 2020
There was a problem hiding this comment.
The updated passages looked good overall. I left a few suggestions in the release version, but each suggestion would apply to all version starting with v3.12.0 (which, I think, is missing in this PR?).
I'd like to request 4 changes:
- Make changes to
v3.12.0as well (unless there was a reason not to). - Include the words
ember-intlandlangas lint exceptions in the file.local.dic. Doing so should help Travis CI pass. - I think we should avoid the reference to
ember new --languntil the feature is implemented. - I think we should avoid style changes in this PR. If you run
git grep -n "^> "in theguides/releasefolder, you will see that the<blockquote>element is used in several places. I do think the current style for<blockquote>isn't great. Updating the style would be better done in a separate PR (I'd open an issue first to invite feedback from general public) and invite @MelSumner and @mansona to provide feedback on what's the best way to update style for Ember Guides.
Can you rebase from the upstream master once more? Percy's "before" snapshots are using an old reference.
hergaiety
force-pushed
the
ember-lang-attribute
branch
from
f9dfc11 to
27b0fa2
Compare
ijlee2
approved these changes
Jul 1, 2020
locks
pushed a commit
to locks/guides-source
that referenced
this pull request
Jul 6, 2020
* Text content rewrite of a11y lang attr * Illustration for sub elements with dif lang * Ported to v3.13-v3.17 * Ported to v3.18 * Applied PR feedback Co-authored-by: Ava Wroten <[email protected]>
This was referenced Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts some copy based on what we've learned during the ember new lang RFC, clarifies some points, adds some reference links, adds a zoey says section and a visual illustration to better explain where the attribute goes.
Styled blockquotes, seems it hasn't been done before? So I just went for it trying to give it a generic but reusable style that seems to match the guides.
Rendered:
