This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] migrate blend tests to DL. #54457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Aug 8, 2024
| @@ -665,7 +665,7 @@ class DlColorFilterImageFilter final : public DlImageFilter { | |||
| class DlLocalMatrixImageFilter final : public DlImageFilter { | |||
| public: | |||
| explicit DlLocalMatrixImageFilter(const SkMatrix& matrix, | |||
| std::shared_ptr<DlImageFilter> filter) | |||
| std::shared_ptr<const DlImageFilter> filter) | |||
There was a problem hiding this comment.
Without this change I can't pass a composed image filter here
added 2 commits
August 8, 2024 23:25
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
commented
Aug 9, 2024
| @@ -623,7 +623,7 @@ void DlDispatcherBase::saveLayer(const SkRect& bounds, | |||
| ? ContentBoundsPromise::kMayClipContents | |||
| : ContentBoundsPromise::kContainsContents; | |||
| std::optional<Rect> impeller_bounds; | |||
| if (!options.content_is_unbounded()) { | |||
| if (!options.content_is_unbounded() || options.bounds_from_caller()) { | |||
There was a problem hiding this comment.
found another bug. even if contents are unbounded, we should still treat them as bounded if the caller specified bounds
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Since there is no SkMatrix::MakeRotationZ, I change a few of the matricies to be easier to represent. |
chinmaygarde
approved these changes
Aug 10, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2024
…153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#142054