Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iOS,docs: Update iOS symbolication docs #54494

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

cbracken
Copy link
Member

As of flutter/flutter#153215, end user app archives now include symbols for the Flutter framework by default. So manual symbolication is no longer required.

For engine developers and others who still need to deal with manual symbols, they can now be found in the Flutter tool cache and can thus be obtained from there if required.

Issue: flutter/flutter#116493

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

As of flutter/flutter#153215, end user app archives now include symbols
for the Flutter framework by default. So manual symbolication is no
longer required.

For engine developers and others who still need to deal with manual
symbols, they can now be found in the Flutter tool cache and can thus be
obtained from there if required.

Issue: flutter/flutter#116493
@cbracken cbracken requested review from jmagman and zanderso August 10, 2024 18:34
@cbracken
Copy link
Member Author

Note that these patches will be proposed for cherry-pick to 3.24 to ensure they're in place for the Xcode 16, iOS 18, macOS 15 release.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2024
@auto-submit auto-submit bot merged commit d409dcd into flutter:main Aug 10, 2024
27 checks passed
@cbracken cbracken deleted the update-crash-docs branch August 10, 2024 19:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 10, 2024
…153233)

flutter/engine@c11fe48...d409dcd

2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494)
2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493)
2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
…lutter#153233)

flutter/engine@c11fe48...d409dcd

2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494)
2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493)
2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#153233)

flutter/engine@c11fe48...d409dcd

2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494)
2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493)
2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants