This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] Rename create_{full_,}ios_framework.py #54493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the iOS framework creation script for consistency with the analogous macOS script. Previously, we had two iOS framework creation scripts: * create_ios_framework.py * create_full_ios_framework.py The former was unused and was deleted in #54227. The addition of "full" is no longer necessary to differentiate the two.
cbracken
commented
Aug 10, 2024
| the code signing recipe module and invoke the function. An example is [how engine V2 invokes the code signing recipe module](https://cs.opensource.google/flutter/recipes/+/master:recipes/engine_v2/engine_v2.py;l=197-212). |
There was a problem hiding this comment.
The diff is that this line had no trailing newline, and as we all know, POSIX therefore says it's no line at all.
Well, that, and my editor added it automatically without me asking.
chinmaygarde
approved these changes
Aug 10, 2024
cbracken
added
the
autosubmit
zanderso
approved these changes
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2024
…153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153233) flutter/engine@c11fe48...d409dcd 2024-08-10 [email protected] iOS,docs: Update iOS symbolication docs (flutter/engine#54494) 2024-08-10 [email protected] [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493) 2024-08-10 [email protected] [Impeller] migrate blend tests to DL. (flutter/engine#54457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the iOS framework creation script for consistency with the analogous macOS script.
Previously, we had two iOS framework creation scripts:
The former was unused and was deleted in #54227. The addition of "full" is no longer necessary to differentiate the two.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.