-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Clarify doc comment on unix OpenOptions #142889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Also am I crazy or is this example nonsensical? use std::fs::OpenOptions;
use std::os::unix::fs::OpenOptionsExt;
let mut options = OpenOptions::new();
options.write(true);
if cfg!(unix) {
options.custom_flags(libc::O_NOFOLLOW);
}
let file = options.open("foo.txt"); You'd want this to be |
The example is already on a trait that is |
Under that analysis, what's the |
Right. When that example is tested, it is always true. |
This is perhaps a bigger issue than this PR seeks to deal with but would it be possible to be rid of the |
|
This comment has been minimized.
This comment has been minimized.
r=me with commits squashed |
…Drop #![feature(rustc_private)]
squashed |
@bors r+ rollup |
Rollup of 11 pull requests Successful merges: - #142021 (Doc: clarify priority of lint level sources) - #142367 (Add regression test for #137857 to ensure that we generate intra doc links for extern crate items.) - #142641 (Generate symbols.o for proc-macros too) - #142889 (Clarify doc comment on unix OpenOptions) - #143063 (explain `ImportData::imported_module`) - #143088 (Improve documentation of `TagEncoding`) - #143135 (fix typos on some doc comments) - #143138 (Port `#[link_name]` to the new attribute parsing infrastructure) - #143155 (`librustdoc` house-keeping 🧹) - #143169 (Remove unused feature gates) - #143171 (Fix the span of trait bound modifier `[const]`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #142889 - nabijaczleweli:rusts, r=Mark-Simulacrum Clarify doc comment on unix OpenOptions
No description provided.