Port #[link_name] to the new attribute parsing infrastructure
#143138
+96
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anne Stijns <[email protected]> Signed-off-by: Jonathan Brouwer <[email protected]>
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_codegen_ssa |
JonathanBrouwer
commented
Jun 28, 2025
| | ^^^^^^^^^^^^ | ||
| | | | ||
| | expected this to be of the form `link_name = "..."` | ||
| | help: must be of the form: `#[link_name = "name"]` |
There was a problem hiding this comment.
This is a little ugly, will be fixed in a seperate PR as it affects all new attributes, not only this one
Filed an issue here: #143136
I should have the PR for this done tomorrow
|
r? @oli-obk |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
bors
added a commit
that referenced
this pull request
Jun 29, 2025
Rollup of 11 pull requests Successful merges: - #142021 (Doc: clarify priority of lint level sources) - #142367 (Add regression test for #137857 to ensure that we generate intra doc links for extern crate items.) - #142641 (Generate symbols.o for proc-macros too) - #142889 (Clarify doc comment on unix OpenOptions) - #143063 (explain `ImportData::imported_module`) - #143088 (Improve documentation of `TagEncoding`) - #143135 (fix typos on some doc comments) - #143138 (Port `#[link_name]` to the new attribute parsing infrastructure) - #143155 (`librustdoc` house-keeping 🧹) - #143169 (Remove unused feature gates) - #143171 (Fix the span of trait bound modifier `[const]`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 29, 2025
Rollup merge of #143138 - JonathanBrouwer:link_name_parser, r=jdonszelmann Port `#[link_name]` to the new attribute parsing infrastructure Ports `link_name` to the new attribute parsing infrastructure for #131229 (comment) r? `@jdonszelmann`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
link_nameto the new attribute parsing infrastructure for #131229 (comment)r? @jdonszelmann