Frontend MVP for Source Academy Rook #1834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y configurations
…kend. Yarn format
…pe routes toLowerCase
… were previously commented out already
…er to use postCourseConfig saga
…anguage on first render
…be hardcoded to assessement types
chownces
force-pushed
the
multitenant/dev
branch
from
99ad3cc to
aaca32d
Compare
This was
linked to
issues
Jul 18, 2021
* Update link to learner page * Fix formatting
chownces
commented
Jul 19, 2021
Comment on lines
55
to
58
| ability: | ||
| assessmentOverview.category === 'Mission' || assessmentOverview.category === 'Path' | ||
| assessmentOverview.type === 'Missions' || assessmentOverview.type === 'Paths' | ||
| ? AchievementAbility.CORE | ||
| : AchievementAbility.EFFORT, |
There was a problem hiding this comment.
probably need the achievements team to remove this hardcode
Comment on lines
71
to
75
| view: { | ||
| coverImage: `${coverImageUrl}/default.png`, | ||
| description: assessmentOverview.shortSummary, | ||
| completionText: `Grade: ${assessmentOverview.grade} / ${assessmentOverview.maxGrade}` | ||
| completionText: `XP: ${assessmentOverview.xp} / ${assessmentOverview.maxXp}` | ||
| } |
Comment on lines
+92
to
+95
| if (data.length + users.length > 1000) { | ||
| setInvalidCsvMsg('Please limit each upload to 1000 entries!'); | ||
| hasInvalidInput = true; | ||
| } |
There was a problem hiding this comment.
still hardcoded to 1000 per upload for now. will be relooked when the super user rights are implemented
Comment on lines
+213
to
+214
| <a href={Links.githubOrg}>GitHub repositories of the Source Academy</a>. Feel free to | ||
| join us! |
* Remove text-align-last * Justify contributors description section
* Update infinite loop detector frontend * Bump js-slang
…academy#1877) * Fix output not appearing in snippets which are not evaluated * Italicise output snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frontend MVP for Source Academy Rook
Status:
To get feedback on UIFrontend mockups not updated yet'Paths' logic is yet to be refactoredAssessment 'Grade' has not been fully removedTo relook at course 'viewability' for admins (it is currently disabled for all when viewable == false)Note: To temporarily disable the create course button for deployment
Changelog (Knight --> Rook):
Added multitenant functionality
Updated frontend routing
Updates to setting of course configuration
New admin panel for course admins
Changes to testcase types
'Grade' metric has been deprecated. Assessments will now solely use XP for grading.
Type of change
How to test
To be tested with the new backend (source-academy/backend#775)
Checklist