[pull] swiftwasm from master #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The static version of the standard library was leaking symbols in the `llvm::` namespace which would result in ODR violations were the artifact linking against `LLVMSupport` (via another dependency). In particular, `llvm::SmallVector` and `llvm::StringSwitch` symbols were being leaked. This adds a test case specifically for the static variant of the library. The dynamic variant of the library is already tested in a separate test.
Rather than passing the result of buildBlock() into buildDo(), follow the (better) design from the function builders pitch by passing in the components from the block directly into buildDo(). This means that buildDo() will need to take separate parameters for each component, but allows buildDo() to treat the components separately.
…atus Update README.md to fix CentOS 8 build status icon
Remove extraneous code. Clarify test name: test/AutoDiff/SIL/Serialization/differentiable_function_type.swift.
…s-broken test: add a ODR violation check for the static standard library
…do-block [Function builders] Align buildDo() implementation with the pitch.
…wiftlang#32106) Forward-mode differentiation development isn't currently prioritized, but upstreaming tests allows us to prevent regressions.
…wiftlang#32110) Enable .swiftinterface verification for the _Differentiation module to prevent regressions.
MaxDesiatov
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )